Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocaleManager: set system locale and keyboard via dbus #205

Merged
merged 14 commits into from
Jun 18, 2024
Merged

LocaleManager: set system locale and keyboard via dbus #205

merged 14 commits into from
Jun 18, 2024
+51 −96

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 14, 2024 •
edited
Loading

As recommended in #147 (comment)

@danirabbit danirabbit requested a review from a team June 14, 2024 17:31
@danirabbit danirabbit marked this pull request as ready for review June 14, 2024 17:31
ryonakano
ryonakano reviewed Jun 15, 2024
View reviewed changes
src/Widgets/LocaleSetting.vala Outdated Show resolved Hide resolved
src/LocaleManager.vala Outdated Show resolved Hide resolved
@ryonakano
Copy link
Contributor

Also, maybe we can update the data/locale.policy.in file?

  • L18 can be removed since we no longer use localectl with pkexec command
  • org.freedesktop.locale1.set-locale in L19 can be removed since we no longer check for permission when set_system_button is clicked

switchboard-plug-locale/data/locale.policy.in

Lines 18 to 19 in 425a664

<annotate key="org.freedesktop.policykit.exec.path">/usr/bin/localectl</annotate>
<annotate key="org.freedesktop.policykit.imply">org.freedesktop.locale1.set-locale org.debian.apt.install-or-remove-packages</annotate>

@danirabbit danirabbit requested a review from ryonakano June 16, 2024 00:20
@danirabbit
Copy link
Member Author

@ryonakano thanks for the thorough review! Addressed those feedback points :)

ryonakano
ryonakano reviewed Jun 16, 2024
View reviewed changes
src/LocaleManager.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from ryonakano June 17, 2024 16:57
ryonakano
ryonakano reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nitpicking, otherwise looks good and works as expected.

src/LocaleManager.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from ryonakano June 18, 2024 16:59
@danirabbit
Copy link
Member Author

@ryonakano thanks for catching that!

@danirabbit danirabbit mentioned this pull request Jun 18, 2024
Merged
ryonakano
ryonakano approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected. Thank you for your work!

@danirabbit
Copy link
Member Author

Thanks for your thorough review!

@danirabbit danirabbit merged commit 2b8aa1e into main Jun 18, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/localemanager-locale1setsystem branch June 18, 2024 22:56
@ryonakano ryonakano mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

@davidmhewitt davidmhewitt Awaiting requested review from davidmhewitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danirabbit @ryonakano @zeebok